+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42677/36766

• This PR adds an extra 16KB to repository

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

type hcal, l1t

please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-973a00/34524/summary.html
COMMIT: 72df35b
CMSSW: CMSSW_13_3_X_2023-08-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42677/34524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 12 lines from the logs
• Reco comparison results: 333 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 119
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152954
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

@emanueleusai are you okay with the main branch PR? You've only signed the backport.

@rappoccio apologies for the non-standard procedure (signing backports before master).
This is on purpose for DQM PRs we test online.
In this particular case, the 13_0 backport was the first version of this PR that appeared, and the one we tested online, so it was approved first once tests were successful.
After the successful P5 tests, the author then provided the master and the other backports, whose tests cleared at a later date. In this particular case we also tested 13_2 online.
This way we keep track of which versions were tested online and are cleared from our side.
I am aware the procedure from the release management point of view is to merge master first then backports, and I am not asking to change that! :)
In the future, I will put on hold the signed backports myself...

+1

• 13_0 and 13_2 tested online with ok feedback from the author
• DQM differences in Tracking and RecoTauV not related to this PR (they do not appear in the backports either)

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

+1